[webkit-reviews] review granted: [Bug 211498] Cut and paste from Google Doc to Notes in several (non-Latin) languages doesn't work : [Attachment 398630] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211498: Cut and paste from Google Doc to Notes in several (non-Latin)
languages doesn't work
https://bugs.webkit.org/show_bug.cgi?id=211498

Attachment 398630: Patch

https://bugs.webkit.org/attachment.cgi?id=398630&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 398630
  --> https://bugs.webkit.org/attachment.cgi?id=398630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398630&action=review

Looks good to me.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:144
> +#if PLATFORM(MAC)
> +	       NSColor *color = (NSColor *)value;
> +#else
> +	       UIColor *color = (UIColor *)value;
> +#endif

We need a CocoaColor typedef so we can write code like this without #if. I
think David Kilzer added CocoaImage recently.