[webkit-reviews] review granted: [Bug 211516] [WebXR] Implement simulateUserActivation() : [Attachment 398622] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 6 09:15:43 PDT 2020

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 211516: [WebXR] Implement simulateUserActivation()

Attachment 398622: Patch


--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 398622
  --> https://bugs.webkit.org/attachment.cgi?id=398622

View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review

> Source/WebCore/testing/WebXRTest.cpp:105
> +    function.handleEvent();

it might be better to follow Internals::withUserGesture.
Something like:
UserGestureIndicator gestureIndicator(ProcessingUserGesture, document);

More information about the webkit-reviews mailing list