[webkit-reviews] review granted: [Bug 211516] [WebXR] Implement simulateUserActivation() : [Attachment 398622] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 6 09:15:43 PDT 2020
youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 211516: [WebXR] Implement simulateUserActivation()
https://bugs.webkit.org/show_bug.cgi?id=211516
Attachment 398622: Patch
https://bugs.webkit.org/attachment.cgi?id=398622&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 398622
--> https://bugs.webkit.org/attachment.cgi?id=398622
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review
> Source/WebCore/testing/WebXRTest.cpp:105
> + function.handleEvent();
it might be better to follow Internals::withUserGesture.
Something like:
UserGestureIndicator gestureIndicator(ProcessingUserGesture, document);
function.handleEvent();
More information about the webkit-reviews
mailing list