[webkit-reviews] review granted: [Bug 211494] Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function : [Attachment 398593] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 211494: Factor EventHandler code that sends
mouseEnteredContentArea/mouseExitedContentArea into its own function
https://bugs.webkit.org/show_bug.cgi?id=211494

Attachment 398593: Patch

https://bugs.webkit.org/attachment.cgi?id=398593&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 398593
  --> https://bugs.webkit.org/attachment.cgi?id=398593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398593&action=review

> Source/WebCore/page/EventHandler.cpp:2627
> +	   if (elementUnderMouse) {
> +	       frameView->mouseEnteredContentArea();
> +	       if (scrollableAreaForNodeUnderMouse)
> +		   scrollableAreaForNodeUnderMouse->mouseEnteredContentArea();
> +	   } else {
> +	       if (scrollableAreaForLastNode)
> +		   scrollableAreaForLastNode->mouseExitedContentArea();
> +	       frameView->mouseExitedContentArea();
> +	   }
> +	   return;

You could early return instead of the else branch.