[webkit-reviews] review granted: [Bug 211480] [Quirk] Job listing page goes blank when scrolling on stackoverflow.com : [Attachment 398572] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 211480: [Quirk] Job listing page goes blank when scrolling on
stackoverflow.com
https://bugs.webkit.org/show_bug.cgi?id=211480

Attachment 398572: Patch

https://bugs.webkit.org/attachment.cgi?id=398572&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 398572
  --> https://bugs.webkit.org/attachment.cgi?id=398572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398572&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1370
> +static RecommedDesktopClassBrowsingForRequest
desktopClassBrowsingRecommendedForRequest(const WebCore::ResourceRequest&
request)

“Recommed"

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1443
> +	   return RecommedDesktopClassBrowsingForRequest::Always;

Nit - it’s not immediately obvious to me what the difference between Always and
Yes is, and I find the asymmetry between No and Yes a bit odd. That said, it’s
admittedly hard to come up with a good name for this :/

What do you think about just No, Yes, Auto?