[webkit-reviews] review granted: [Bug 211473] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS : [Attachment 398554] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 211473: fast/overflow/horizontal-scroll-after-back.html is a flaky timeout
on macOS
https://bugs.webkit.org/show_bug.cgi?id=211473

Attachment 398554: Patch

https://bugs.webkit.org/attachment.cgi?id=398554&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 398554
  --> https://bugs.webkit.org/attachment.cgi?id=398554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398554&action=review

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:20
> +    window.sessionStorage.horizontal_scroll_after_back_test_started = true;

I don’t think we need the "window." here.

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:30
> +    window.setTimeout("navigateAwayAndBack()", 0);

I don’t think we need the "window." here.

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:37
> +    if (!window.sessionStorage.horizontal_scroll_after_back_test_started)
> +	   return;
> +    delete window.sessionStorage.horizontal_scroll_after_back_test_started;

I don’t think we need the "window." here.