[webkit-reviews] review granted: [Bug 198276] Web Inspector: REGRESSION(r239175): Source Maps: original source not shown when in nested folder : [Attachment 398433] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198276: Web Inspector: REGRESSION(r239175): Source Maps: original source
not shown when in nested folder
https://bugs.webkit.org/show_bug.cgi?id=198276

Attachment 398433: Patch

https://bugs.webkit.org/attachment.cgi?id=398433&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 398433
  --> https://bugs.webkit.org/attachment.cgi?id=398433
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398433&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:392
> +	   this.children = [];

I like this much better. I suppose it is possible that in response to an
element being removed someone could add a child.. but `removeChildren` is a
remove of all children, so you should be left with nothing at the end.