[webkit-reviews] review granted: [Bug 209772] [ECMA-402] Implement Intl.Locale : [Attachment 398303] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted  review:
Bug 209772: [ECMA-402] Implement Intl.Locale
https://bugs.webkit.org/show_bug.cgi?id=209772

Attachment 398303: Patch

https://bugs.webkit.org/attachment.cgi?id=398303&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 398303
  --> https://bugs.webkit.org/attachment.cgi?id=398303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398303&action=review

>> Source/JavaScriptCore/runtime/IntlLocale.cpp:79
>> +	if (needsToGrowToProduceBuffer(status)) {
> 
> This is wrong. It needs to be:
> needsToGrowToProduceCString

Sorry I think I'm wrong here based on your usage. Reinstating Darin's r+

> Source/JavaScriptCore/runtime/IntlLocale.cpp:95
> +    auto bufferLength = uloc_canonicalize(m_localeID.data(), buffer.data(),
buffer.size(), &status);

Looks like the same issue.