[webkit-reviews] review denied: [Bug 209772] [ECMA-402] Implement Intl.Locale : [Attachment 398303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 5 11:39:16 PDT 2020


Saam Barati <sbarati at apple.com> has denied  review:
Bug 209772: [ECMA-402] Implement Intl.Locale
https://bugs.webkit.org/show_bug.cgi?id=209772

Attachment 398303: Patch

https://bugs.webkit.org/attachment.cgi?id=398303&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 398303
  --> https://bugs.webkit.org/attachment.cgi?id=398303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398303&action=review

> Source/JavaScriptCore/runtime/IntlLocale.cpp:79
> +    if (needsToGrowToProduceBuffer(status)) {

This is wrong. It needs to be:
needsToGrowToProduceCString


More information about the webkit-reviews mailing list