[webkit-reviews] review granted: [Bug 211451] Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols. : [Attachment 398521] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 211451: Check for app-bound domains should confirm WKAppBoundDomains key
exists when checking for default app-bound protocols.
https://bugs.webkit.org/show_bug.cgi?id=211451

Attachment 398521: Patch

https://bugs.webkit.org/attachment.cgi?id=398521&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 398521
  --> https://bugs.webkit.org/attachment.cgi?id=398521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398521&action=review

Looks good. r=me.

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:465
> +	   // Must check for both an empty app bound domains and an empty key
before returning nullopt

"both an empty app bound domains ..." maybe add set? or array? -- the plural
domains with the 'an' is throwing me off.