[webkit-reviews] review granted: [Bug 211359] [Intl] Alphabetize extension keys and correctly mark const methods : [Attachment 398333] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 5 10:29:42 PDT 2020
Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 211359: [Intl] Alphabetize extension keys and correctly mark const methods
https://bugs.webkit.org/show_bug.cgi?id=211359
Attachment 398333: Patch
https://bugs.webkit.org/attachment.cgi?id=398333&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 398333
--> https://bugs.webkit.org/attachment.cgi?id=398333
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=398333&action=review
> Source/JavaScriptCore/runtime/IntlCollator.cpp:47
> +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" };
There’s a redundant const here. Given constexpr, don’t need the const after the
"*".
More information about the webkit-reviews
mailing list