[webkit-reviews] review granted: [Bug 209079] [ Mac ] fast/animation/request-animation-frame-timestamps.html is flaky failing. : [Attachment 398482] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 209079: [ Mac ] fast/animation/request-animation-frame-timestamps.html is
flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209079

Attachment 398482: Patch

https://bugs.webkit.org/attachment.cgi?id=398482&action=review




--- Comment #7 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 398482
  --> https://bugs.webkit.org/attachment.cgi?id=398482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398482&action=review

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:12
> +	   while (Date.now()-start < millis) {}

Could you use `performance.now()` here instead?

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:17
> +	       window.requestAnimationFrame(function(timestamp) {

You're mixing arrow-syntax and `function`, could you use a consistent style?

> LayoutTests/fast/animation/request-animation-frame-timestamps.html:37
> +    Promise.all([firstRequestAnimationFrame(),
secondRequestAnimationFrame()]).then((timestamps) => {

Nit: no need for the `()` around `timestamps`. You could also use `await` for
Promise.all() instead of `then()`.