[webkit-reviews] review granted: [Bug 211200] Style is not applied when changed on the first line of a new mail message. : [Attachment 398448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 23:43:03 PDT 2020

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 211200: Style is not applied when changed on the first line of a new mail

Attachment 398448: Patch


--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 398448
  --> https://bugs.webkit.org/attachment.cgi?id=398448

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

r=me after you get the test to pass on EWS; right now it’s failing

> Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:71
> +    [[webView() window] makeFirstResponder:nil];
> +#else
>      [webView() resignFirstResponder];
> +#endif

I don’t think you should land this Mac-only change as part of this patch, since
the test is an iOS-only test. I assume it’s not needed to make some other test
pass on Mac?

I believe UIScriptControllerCocoa::becomeFirstResponder is also incorrect on
Mac in the same sort of way. And should be fixed the same way, by calling
[window makeFirstResponder:self]. Maybe not right now as part of this patch,

> LayoutTests/ChangeLog:10
> +	   *
ing-first-responder.html: Added.

Why is this an iOS-only test? I couldn't find anything iOS-specific in it.

More information about the webkit-reviews mailing list