[webkit-reviews] review granted: [Bug 211200] Style is not applied when changed on the first line of a new mail message. : [Attachment 398448] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 211200: Style is not applied when changed on the first line of a new mail
message.
https://bugs.webkit.org/show_bug.cgi?id=211200

Attachment 398448: Patch

https://bugs.webkit.org/attachment.cgi?id=398448&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 398448
  --> https://bugs.webkit.org/attachment.cgi?id=398448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398448&action=review

r=me after you get the test to pass on EWS; right now it’s failing

> Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:71
> +#if PLATFORM(MAC)
> +    [[webView() window] makeFirstResponder:nil];
> +#else
>      [webView() resignFirstResponder];
> +#endif

I don’t think you should land this Mac-only change as part of this patch, since
the test is an iOS-only test. I assume it’s not needed to make some other test
pass on Mac?

I believe UIScriptControllerCocoa::becomeFirstResponder is also incorrect on
Mac in the same sort of way. And should be fixed the same way, by calling
[window makeFirstResponder:self]. Maybe not right now as part of this patch,
though.

> LayoutTests/ChangeLog:10
> +	   *
editing/execCommand/ios/first-line-text-attribute-change-presist-through-resign
ing-first-responder.html: Added.

Why is this an iOS-only test? I couldn't find anything iOS-specific in it.