[webkit-reviews] review requested: [Bug 211360] Improve accuracy of IndexedDB estimated write size computation : [Attachment 398454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 22:03:26 PDT 2020


Ben Nham <nham at apple.com> has asked  for review:
Bug 211360: Improve accuracy of IndexedDB estimated write size computation
https://bugs.webkit.org/show_bug.cgi?id=211360

Attachment 398454: Patch

https://bugs.webkit.org/attachment.cgi?id=398454&action=review




--- Comment #8 from Ben Nham <nham at apple.com> ---
Comment on attachment 398454
  --> https://bugs.webkit.org/attachment.cgi?id=398454
Patch

Addressed patch feedback:
 - Fixed estimates for multi-entry indices
 - Added layout test (should I delete the API test?)
 - Added bailout if indices can't be found (this shouldn't happen so it is also
protected by an assert)
 - Moved check farther down


More information about the webkit-reviews mailing list