[webkit-reviews] review granted: [Bug 211395] [JSC] DFG NotCellUse is used without considering about BigInt32 : [Attachment 398426] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 21:39:38 PDT 2020

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 211395: [JSC] DFG NotCellUse is used without considering about BigInt32

Attachment 398426: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 398426
  --> https://bugs.webkit.org/attachment.cgi?id=398426

View in context: https://bugs.webkit.org/attachment.cgi?id=398426&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:10849
> +    GPRReg tempGPR = temp.gpr();

Gonna be unused when USE(BIGINT32) is false

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:17609
> +	   LValue nonCell = lowNotCell(edge);

You’re gonna need an UNUSED_PARAM below this for non bigint32

More information about the webkit-reviews mailing list