[webkit-reviews] review granted: [Bug 211402] Make __IPHONE_OS_VERSION_MIN_REQUIRED checks against old versions explicit about watchOS and tvOS : [Attachment 398447] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 211402: Make __IPHONE_OS_VERSION_MIN_REQUIRED checks against old versions
explicit about watchOS and tvOS
https://bugs.webkit.org/show_bug.cgi?id=211402

Attachment 398447: Patch

https://bugs.webkit.org/attachment.cgi?id=398447&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 398447
  --> https://bugs.webkit.org/attachment.cgi?id=398447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398447&action=review

> Source/WebKit/ChangeLog:12
> +	   * Platform/spi/ios/UIKitSPI.h: Move from
__IPHONE_OS_VERSION_MIN_REQUIRED to
> +	   PLATFORM(IOS) in one place, and in the other removed the conditional
entirely.

I went back here to find out why there isn't a comment about watchOS and tvOS
in the code.

> Source/WebCore/page/SettingsDefaultValues.h:109
> +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <
101400) && !PLATFORM(APPLETV)

There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400.

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:187
> +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <
101400) && !PLATFORM(APPLETV)

Ditto.

> Source/WebKit/NetworkProcess/NetworkActivityTracker.h:31
> +#if USE(APPLE_INTERNAL_SDK) && PLATFORM(COCOA) && !(PLATFORM(MAC) &&
__MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(APPLETV)

There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400.

> Source/WebKit/Shared/WebPreferencesDefaultValues.h:225
> +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <
101400) && !PLATFORM(APPLETV)

There is no __MAC_OS_X_VERSION_MIN_REQUIRED < 101400.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:352
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) ||
PLATFORM(IOS)

It's always __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400