[webkit-reviews] review granted: [Bug 211383] [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks : [Attachment 398373] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 211383: [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED
checks
https://bugs.webkit.org/show_bug.cgi?id=211383

Attachment 398373: Patch

https://bugs.webkit.org/attachment.cgi?id=398373&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 398373
  --> https://bugs.webkit.org/attachment.cgi?id=398373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review

> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) ||
PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)

This check can be removed now, 10.14 is the oldest supported version for macOS.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534
>  #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400

This can be removed too. We are 13.4+ now.