[webkit-reviews] review granted: [Bug 211389] Remove HAVE(IOSURFACE) checks in Cocoa-platform-specific code : [Attachment 398403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 16:24:06 PDT 2020

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 211389: Remove HAVE(IOSURFACE) checks in Cocoa-platform-specific code

Attachment 398403: Patch


--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 398403
  --> https://bugs.webkit.org/attachment.cgi?id=398403

View in context: https://bugs.webkit.org/attachment.cgi?id=398403&action=review

> Source/WebKit/ChangeLog:35
> +	   Merged #if expressions into a single one.

I went back to ChangeLog to understand why. Since this is in Cocoa directory,
when is HAVE(IOSURFACE) false here?

> Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:-58
> -    // TODO: <rdar://problem/6558366> DumpRenderTree: Investigate
testRepaintSweepHorizontally and dumpSelectionRect

I'm not sure if/how the TODO is related to BEGIN_BLOCK_OBJC_EXCEPTIONS. In
fact, they were added at different times. Perhaps it should stay?

More information about the webkit-reviews mailing list