[webkit-reviews] review granted: [Bug 211388] ResourceLoadStatisticsDatabaseStore checks 'hasHadUserInteraction' without ensuring the domain has been added to the ITP database : [Attachment 398398] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 4 12:57:41 PDT 2020
John Wilander <wilander at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 211388: ResourceLoadStatisticsDatabaseStore checks 'hasHadUserInteraction'
without ensuring the domain has been added to the ITP database
https://bugs.webkit.org/show_bug.cgi?id=211388
Attachment 398398: Patch
https://bugs.webkit.org/attachment.cgi?id=398398&action=review
--- Comment #12 from John Wilander <wilander at apple.com> ---
Comment on attachment 398398
--> https://bugs.webkit.org/attachment.cgi?id=398398
Patch
Good catch! This change matches the order in the memory store:
auto& statistics = ensureResourceStatisticsForRegistrableDomain(domain);
bool didHavePreviousUserInteraction = statistics.hadUserInteraction;
statistics.hadUserInteraction = true;
More information about the webkit-reviews
mailing list