[webkit-reviews] review granted: [Bug 202137] IndexedDB WAL file keeps growing while app is in use : [Attachment 398306] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 4 11:50:37 PDT 2020
Brady Eidson <beidson at apple.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 202137: IndexedDB WAL file keeps growing while app is in use
https://bugs.webkit.org/show_bug.cgi?id=202137
Attachment 398306: Patch
https://bugs.webkit.org/attachment.cgi?id=398306&action=review
--- Comment #15 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 398306
--> https://bugs.webkit.org/attachment.cgi?id=398306
Patch
Looks good.
I don't love the SQLiteStatementAutoResetScope class name. It's really more of
"a SQLiteStatement that knows when to reset itself", but the class name
suggests "a scope that resets SQLiteStatements"
But I can't think of an obviously clearer name.
More information about the webkit-reviews
mailing list