[webkit-reviews] review granted: [Bug 211290] Receiving WebRTC network packets should not go through the main thread : [Attachment 398362] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 4 10:22:30 PDT 2020
Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 211290: Receiving WebRTC network packets should not go through the main
thread
https://bugs.webkit.org/show_bug.cgi?id=211290
Attachment 398362: Patch
https://bugs.webkit.org/attachment.cgi?id=398362&action=review
--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 398362
--> https://bugs.webkit.org/attachment.cgi?id=398362
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=398362&action=review
> Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:119
> + if (auto* socket = m_socketFactory.socket(identifier))
You should probably add assertions to these.
ASSERT(!RunLoop::isMain());
More information about the webkit-reviews
mailing list