[webkit-reviews] review granted: [Bug 211354] Use default initializers and default constructors in WebEvent.h : [Attachment 398321] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 3 12:02:34 PDT 2020
Daniel Bates <dbates at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 211354: Use default initializers and default constructors in WebEvent.h
https://bugs.webkit.org/show_bug.cgi?id=211354
Attachment 398321: Patch v1
https://bugs.webkit.org/attachment.cgi?id=398321&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 398321
--> https://bugs.webkit.org/attachment.cgi?id=398321
Patch v1
Patch looks good. A good future investigation is to identify if the default
constructors are needed. If not, remove them and look for ways to reduce
default initializers to minimum set because they have a cost.
More information about the webkit-reviews
mailing list