[webkit-reviews] review denied: [Bug 211032] [Flatpak SDK] Misc flatpakutils.py fixes : [Attachment 398300] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 211032: [Flatpak SDK] Misc flatpakutils.py fixes
https://bugs.webkit.org/show_bug.cgi?id=211032

Attachment 398300: Patch

https://bugs.webkit.org/attachment.cgi?id=398300&action=review




--- Comment #12 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 398300
  --> https://bugs.webkit.org/attachment.cgi?id=398300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398300&action=review

> Tools/flatpak/flatpakutils.py:845
> +	       icc_version_filename, = re.findall(rb'.*creating (.*)',
tmpfile.read())

Breaks EWS:

Traceback (most recent call last):
  File "Tools/Scripts/update-webkit-flatpak", line 25, in <module>
    from flatpakutils import WebkitFlatpak
  File "./Tools/flatpak/flatpakutils.py", line 851
    icc_version_filename, = re.findall(rb'.*creating (.*)', tmpfile.read())
							 ^
SyntaxError: invalid syntax