[webkit-reviews] review granted: [Bug 211342] Make it possible to test overlay scrollbar interactions : [Attachment 398296] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 2 14:20:03 PDT 2020
Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 211342: Make it possible to test overlay scrollbar interactions
https://bugs.webkit.org/show_bug.cgi?id=211342
Attachment 398296: Patch
https://bugs.webkit.org/attachment.cgi?id=398296&action=review
--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 398296
--> https://bugs.webkit.org/attachment.cgi?id=398296
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=398296&action=review
> Source/WebCore/testing/Internals.cpp:2756
> +ExceptionOr<ScrollableArea*> Internals::scrollableAreaForNode(RefPtr<Node>&
node) const
OK as-is. No change needed. This change makes node an out-argument. Is this OK?
Optimal solutions in previous comment.
More information about the webkit-reviews
mailing list