[webkit-reviews] review granted: [Bug 211266] REGRESSION (r258994): Prevents diagnostic logging of network resource loads : [Attachment 398121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 1 23:53:21 PDT 2020


Maciej Stachowiak <mjs at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 211266: REGRESSION (r258994): Prevents diagnostic logging of network
resource loads
https://bugs.webkit.org/show_bug.cgi?id=211266

Attachment 398121: Patch

https://bugs.webkit.org/attachment.cgi?id=398121&action=review




--- Comment #6 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 398121
  --> https://bugs.webkit.org/attachment.cgi?id=398121
Patch

Maybe this is a stretch, but is it possible to make an API test that verifies
that logging happens when it's supposed to (and not when it isn't supposed to,
i.e. private browsing)?

In any case, r=me


More information about the webkit-reviews mailing list