[webkit-reviews] review granted: [Bug 199138] Object.prototype.toString is not spec-perfect : [Attachment 398257] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 199138: Object.prototype.toString is not spec-perfect
https://bugs.webkit.org/show_bug.cgi?id=199138

Attachment 398257: Patch

https://bugs.webkit.org/attachment.cgi?id=398257&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 398257
  --> https://bugs.webkit.org/attachment.cgi?id=398257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398257&action=review

If any of these are particular hot in performance benchmarks we could probably
optimize this further. Not sure we need to make a rope every time.

Also, if toStringName is always returning an ASCIILiteral we should consider
changing its return type from String to ASCIILiteral.

> Source/JavaScriptCore/runtime/ObjectPrototype.cpp:341
> +	   jsTag = jsNontrivialString(vm, WTFMove(tag));

I think this is likely wrong. What guarantees this tag is never a single
character?