[webkit-reviews] review granted: [Bug 211244] Web Inspector: Worker: should use the name of the worker if it exists : [Attachment 398084] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 211244: Web Inspector: Worker: should use the name of the worker if it
exists
https://bugs.webkit.org/show_bug.cgi?id=211244

Attachment 398084: Patch

https://bugs.webkit.org/attachment.cgi?id=398084&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 398084
  --> https://bugs.webkit.org/attachment.cgi?id=398084
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398084&action=review

r=me great cleanup!

Please investigate Windows EWS failure:

C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSou
rces\ForwardingHeaders\JavaScriptCore/InspectorFrontendDispatchers.h(351,10):
message : see declaration of
'Inspector::WorkerFrontendDispatcher::workerCreated' (compiling source file
C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSou
rces\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp)
[C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\We
bCore\WebCore.vcxproj]

> LayoutTests/inspector/worker/runtime-basic-expected.txt:13
>  Target - Page - location and href - Location:
inspector/worker/runtime-basic.html
>  

Very nice!