[webkit-reviews] review granted: [Bug 209763] Web Inspector: provide a way for inspector to turn on/off ITP debug mode and AdClickAttribution debug mode : [Attachment 397934] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 1 15:55:43 PDT 2020


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 209763: Web Inspector: provide a way for inspector to turn on/off ITP debug
mode and AdClickAttribution debug mode
https://bugs.webkit.org/show_bug.cgi?id=209763

Attachment 397934: Patch

https://bugs.webkit.org/attachment.cgi?id=397934&action=review




--- Comment #9 from Brian Burg <bburg at apple.com> ---
Comment on attachment 397934
  --> https://bugs.webkit.org/attachment.cgi?id=397934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397934&action=review

r=me, please investigate Windows EWS failure:

  UnifiedSource-f74e0903-3.cpp
C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector/agent
s/InspectorPageAgent.cpp(464,1): error C2051: case expression not constant
(compiling source file
C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSou
rces\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp)
[C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\We
bCore\WebCore.vcxproj]

> Source/WebInspectorUI/ChangeLog:12
> +	       Enable: [ ] ITP Debug Mode

If we have documentation for these things, then a link to that documentation
from the settings page would be Awesome.

If not, shouldn't we document it?


More information about the webkit-reviews mailing list