[webkit-reviews] review granted: [Bug 210766] [WebGL2] Refactor texImage2D and texSubImage2D taking ImageBitmap, ImageData, Image, ArrayBufferView : [Attachment 398220] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 210766: [WebGL2] Refactor texImage2D and texSubImage2D taking ImageBitmap,
ImageData, Image, ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=210766

Attachment 398220: Patch

https://bugs.webkit.org/attachment.cgi?id=398220&action=review




--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 398220
  --> https://bugs.webkit.org/attachment.cgi?id=398220
Patch

Our review tool can't handle this large a patch. Hopefully the cq does.

I had a couple of minor comments that can be fixed in a follow-up. e.g. using
enum class for TexFuncValidationSourceType and others.

Thanks Ken, this is fantastic.