[webkit-reviews] review canceled: [Bug 209260] Add SPI to move localStorage to a different domain : [Attachment 398238] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 1 14:23:23 PDT 2020

Alex Christensen <achristensen at apple.com> has canceled Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 209260: Add SPI to move localStorage to a different domain

Attachment 398238: Patch


--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 398238
  --> https://bugs.webkit.org/attachment.cgi?id=398238

View in context: https://bugs.webkit.org/attachment.cgi?id=398238&action=review

Turns out this is better than alternatives.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:83
> +- (void)_renameOrigin:(NSURL *)oldName to:(NSURL *)newName
forDataOfTypes:(NSSet<NSString *> *)dataTypes completionHandler:(void

I changed these from NSStrings to NSURLs and _renameDomain to _renameOrigin

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2415
> +	       networkProcess->addSession(*this);

I also add the session if it hasn't been added yet so the use case works.

More information about the webkit-reviews mailing list