[webkit-reviews] review granted: [Bug 211238] [iOS] Every running WebContent process should be granted access to frontboard services when Accessibility is enabled : [Attachment 398059] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 211238: [iOS] Every running WebContent process should be granted access to
frontboard services when Accessibility is enabled
https://bugs.webkit.org/show_bug.cgi?id=211238

Attachment 398059: Patch

https://bugs.webkit.org/attachment.cgi?id=398059&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 398059
  --> https://bugs.webkit.org/attachment.cgi?id=398059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398059&action=review

Patch looks good.

> Tools/TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:87
> +    ASSERT_TRUE(sandboxAccess());

Ok as is. No change needed. Optimal patch uses EXPECT_TRUE() to future proof
this code should any more asserts be added.