[webkit-reviews] review granted: [Bug 211278] Reduce data copies in the WebContent process custom URL scheme handler : [Attachment 398160] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 211278: Reduce data copies in the WebContent process custom URL scheme
handler
https://bugs.webkit.org/show_bug.cgi?id=211278

Attachment 398160: Patch

https://bugs.webkit.org/attachment.cgi?id=398160&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 398160
  --> https://bugs.webkit.org/attachment.cgi?id=398160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398160&action=review

Patch looks good.

> Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h:62
> +    void taskDidReceiveBuffer(uint64_t taskIdentifier,
Ref<WebCore::SharedBuffer>&& data);

Ok as is. No change needed. Optimal solution doesn't name the buffer arg.