[webkit-reviews] review granted: [Bug 211246] [GTK] Add additional exports to support hidden visibility : [Attachment 398198] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 211246: [GTK] Add additional exports to support hidden visibility
https://bugs.webkit.org/show_bug.cgi?id=211246

Attachment 398198: Patch

https://bugs.webkit.org/attachment.cgi?id=398198&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 398198
  --> https://bugs.webkit.org/attachment.cgi?id=398198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398198&action=review

Wow, that must have been a lot of EWSing. I wonder what this will break....

> Source/WTF/wtf/ASCIICType.cpp:30
> -WTF_EXPORT_PRIVATE const unsigned char asciiCaseFoldTable[256] = {
> +const unsigned char asciiCaseFoldTable[256] = {

Since you're changing this anyway... should use static keyword to restrict it
to file scope.

> Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:707
> -extern "C" void
webkit_web_extension_initialize_with_user_data(WebKitWebExtension* extension,
GVariant* userData)
> +extern "C" WTF_EXPORT_DECLARATION void
webkit_web_extension_initialize_with_user_data(WebKitWebExtension* extension,
GVariant* userData)

I guess WTF_EXPORT_DECLARATION is probably a suitable macro to choose for
these. Not much benefit in creating a new one. OK.