[webkit-reviews] review granted: [Bug 209826] Make FrameView and Frame TextStream-loggable : [Attachment 395078] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 12:34:53 PDT 2020


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 209826: Make FrameView and Frame TextStream-loggable
https://bugs.webkit.org/show_bug.cgi?id=209826

Attachment 395078: Patch

https://bugs.webkit.org/attachment.cgi?id=395078&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 395078
  --> https://bugs.webkit.org/attachment.cgi?id=395078
Patch

I totally want to reverse the ValueOrNull thing for TextStream. By default
pointers should log "value of pointed to thing or null" and we should have a
function you can call on a pointer to make it instead log a hex pointer value.

Also, if we keep ValueOrNull we can leave off the "OrNull" part. The real
question is whether to log the pointer or the pointed-to thing. Not sure the
word "value" is unambiguous about that, but it’s cool.


More information about the webkit-reviews mailing list