[webkit-reviews] review granted: [Bug 209814] [macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox : [Attachment 395079] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 209814: [macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
https://bugs.webkit.org/show_bug.cgi?id=209814

Attachment 395079: Patch

https://bugs.webkit.org/attachment.cgi?id=395079&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 395079
  --> https://bugs.webkit.org/attachment.cgi?id=395079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395079&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:276
> +    // Map Launch Services database

WebKit coding style asks for a "." here.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:360
> +#if HAVE(CSCHECKFIXDISABLE)
> +	       // _CSCheckFixDisable() needs to be called before checking in
with Launch Services.
> +	       _CSCheckFixDisable();
> +#endif

Why does’t this belong inside the launchServicesCheckIn function?