[webkit-reviews] review granted: [Bug 209680] REGRESSION (r259095): ASSERTION FAILED: m_videoFullscreenMode != VideoFullscreenModeNone seen with TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS : [Attachment 395004] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 209680: REGRESSION (r259095): ASSERTION FAILED: m_videoFullscreenMode !=
VideoFullscreenModeNone seen with
TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
https://bugs.webkit.org/show_bug.cgi?id=209680

Attachment 395004: Patch

https://bugs.webkit.org/attachment.cgi?id=395004&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 395004
  --> https://bugs.webkit.org/attachment.cgi?id=395004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395004&action=review

> Source/WebCore/ChangeLog:10
> +	   Call fullscreenModeChanged(VideoFullscreenModeNone) right before
call the

s/before call the/before calling the/

> Source/WebKitLegacy/mac/ChangeLog:10
> +	   With this patch, the WebKit-Legacy can support multiple video
elements request
> +	   to enter video fullscreen almost at the same time, and only the last
one will succeed.
> +	   Also, this patch fixes webkit.org/b/209610 for WebKit-Legacy.

This should have a test.