[webkit-reviews] review granted: [Bug 209789] [iPad] Use AVAudioSession to detect AirPlay route changes : [Attachment 395055] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 209789: [iPad] Use AVAudioSession to detect AirPlay route changes
https://bugs.webkit.org/show_bug.cgi?id=209789

Attachment 395055: Patch

https://bugs.webkit.org/attachment.cgi?id=395055&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 395055
  --> https://bugs.webkit.org/attachment.cgi?id=395055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395055&action=review

r=me with nits.

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:106
> +void activeAudioRouteDidChange(bool);
> +void activeVideoRouteDidChange();

Weird spacing here.

> Source/WebCore/platform/graphics/MediaPlaybackTarget.h:47
> +    virtual bool supportsAirPlayVideo() const = 0;

It's kind of weird to have the term "AirPlay" here in a cross-port header. 
Could we change this to "supportsRemoteVideoPlayback" or something?