[webkit-reviews] review denied: [Bug 202276] [GTK] Fix logic of dark theme detection : [Attachment 394977] Patch

[bugzilla-daemon at webkit.org]

Patrick Griffis <pgriffis at igalia.com> has denied Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 202276: [GTK] Fix logic of dark theme detection
https://bugs.webkit.org/show_bug.cgi?id=202276

Attachment 394977: Patch

https://bugs.webkit.org/attachment.cgi?id=394977&action=review




--- Comment #11 from Patrick Griffis <pgriffis at igalia.com> ---
Comment on attachment 394977
  --> https://bugs.webkit.org/attachment.cgi?id=394977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394977&action=review

>>> Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:574
>>>	     return true;
>> 
>> Patrick, is this OK?
> 
> I don't think it is. Just check GTK code instead of guessing:
> 
> https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-24/gtk/gtksettings.c#L3255
> 
> ':' is only used to check the theme variant for the GTK_THEME env variable.

As carlos said :dark is a variant and not part of the theme name.