[webkit-reviews] review granted: [Bug 209794] REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc : [Attachment 395011] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 30 20:19:51 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 209794: REGRESSION (r251574, r251600): _WKTextManipulationToken and
_WKTextManipulationConfiguration are missing -dealloc
https://bugs.webkit.org/show_bug.cgi?id=209794

Attachment 395011: Patch v1

https://bugs.webkit.org/attachment.cgi?id=395011&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 395011
  --> https://bugs.webkit.org/attachment.cgi?id=395011
Patch v1

We usually solve this problem with RetainPtr, but this works too.


More information about the webkit-reviews mailing list