[webkit-reviews] review canceled: [Bug 209644] WebsiteDataStore::parameters() of non-Cocoa port should set parameters.networkSessionParameters.resourceLoadStatisticsParameters : [Attachment 394889] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 209644: WebsiteDataStore::parameters() of non-Cocoa port should set
parameters.networkSessionParameters.resourceLoadStatisticsParameters
https://bugs.webkit.org/show_bug.cgi?id=209644

Attachment 394889: Patch

https://bugs.webkit.org/attachment.cgi?id=394889&action=review




--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 394889
  --> https://bugs.webkit.org/attachment.cgi?id=394889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394889&action=review

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2221
>> +	};
> 
> There is a lot of code shared with WebsiteDataStoreParameters
WebsiteDataStore::parameters() in WebsiteDataStoreCocoa.mm.
> Can we try sharing it?
> GTP seems to have an issue with hasStatisticsTestingCallback.

Good idea. Will do so.