[webkit-reviews] review requested: [Bug 209760] Web Inspector: the Dock Side navigation item is automatically focused when Web Inspector is opened detached, preventing any global spacebar shortcuts from working : [Attachment 394986] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 209760: Web Inspector: the Dock Side navigation item is automatically
focused when Web Inspector is opened detached, preventing any global spacebar
shortcuts from working
https://bugs.webkit.org/show_bug.cgi?id=209760

Attachment 394986: Patch

https://bugs.webkit.org/attachment.cgi?id=394986&action=review




--- Comment #4 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 394986

  --> https://bugs.webkit.org/attachment.cgi?id=394986&action=review

Patch

This is the least ugliest fix I could come up with.

---

I've tried restoring focus in WI.TabBar.prototype.didLayoutSubtree. That fixed
the problem described in the bug, but it didn't fix this:

1. Inspect any page
2. Dock Web Inspector
3. Go to the Timelines Tab
4. Undock Web Inspector (by pressing Command-Shift-D, for example)

My current patch does fix it.

---

I tried restoring focus on requestAnimationFrame. It didn't work.

I've tried restoring focus after a timeout. It introduced flickering. Also, it
was even uglier than my current patch.