[webkit-reviews] review granted: [Bug 209754] Overrides of ActiveDOMObject::hasPendingActivity() should not need to query the base class's hasPendingActivity() : [Attachment 394980] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 209754: Overrides of ActiveDOMObject::hasPendingActivity() should not need
to query the base class's hasPendingActivity()
https://bugs.webkit.org/show_bug.cgi?id=209754

Attachment 394980: Patch

https://bugs.webkit.org/attachment.cgi?id=394980&action=review




--- Comment #19 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 394980
  --> https://bugs.webkit.org/attachment.cgi?id=394980
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394980&action=review

r=me

>> Source/WebCore/dom/ActiveDOMObject.h:153
>> +	unsigned m_pendingActivityInstancesCount { 0 };
> 
> I renamed this to address the confusion that Ryosuke was talking about.

I think we usually say "m_pendingActivityInstanceCount", without the plural.