[webkit-reviews] review granted: [Bug 209668] REGRESSION: [ Mac wk2 Release ] Flaky crash in WebCore::MediaPlayer::createVideoFullscreenLayer : [Attachment 394955] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 209668: REGRESSION: [ Mac wk2 Release ] Flaky crash in
WebCore::MediaPlayer::createVideoFullscreenLayer
https://bugs.webkit.org/show_bug.cgi?id=209668

Attachment 394955: Patch

https://bugs.webkit.org/attachment.cgi?id=394955&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 394955
  --> https://bugs.webkit.org/attachment.cgi?id=394955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394955&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6246
> -    return m_player->createVideoFullscreenLayer();
> +    if (m_player)
> +	   return m_player->createVideoFullscreenLayer();
> +    return nullptr;

Should be nil; this is an Objective-C class. Also would be good to do early
return since that’s the WebKit "official" style.

Did you check that the callers can all handle nil?

> Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:117
> +    return nullptr;

Ditto.