[webkit-reviews] review granted: [Bug 178174] Add support in named capture group identifiers for direct surrogate pairs : [Attachment 394770] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted	review:
Bug 178174: Add support in named capture group identifiers for direct surrogate
pairs
https://bugs.webkit.org/show_bug.cgi?id=178174

Attachment 394770: Patch

https://bugs.webkit.org/attachment.cgi?id=394770&action=review




--- Comment #10 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 394770
  --> https://bugs.webkit.org/attachment.cgi?id=394770
Patch

r-me

This looks great.  The only change I recommend is changing the template
parameter for tryConsumeUnicodeEscape() from a boolean to an enum.  That way
the template parameter at the call site describes the behavior.  Just a
suggestion, but use enum values something like AsCodePoint and
AsIdentifierCharacter.