[webkit-reviews] review granted: [Bug 209746] http://webkit.org/css-status/ hangs : [Attachment 394922] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 30 09:00:18 PDT 2020


Antoine Quint <graouts at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 209746: http://webkit.org/css-status/ hangs
https://bugs.webkit.org/show_bug.cgi?id=209746

Attachment 394922: Patch

https://bugs.webkit.org/attachment.cgi?id=394922&action=review




--- Comment #2 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 394922
  --> https://bugs.webkit.org/attachment.cgi?id=394922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394922&action=review

> Websites/webkit.org/wp-content/themes/webkit/css-status.php:1604
> +	   for (var valueObj of prefixedValues) {

Two potential improvements here:

1. use `const` instead of `var` when declaring `prefixedValues`.
2. do not declare that value and just have `for (var valueObj of
Array.from(prefixedPropertyObj.values))`


More information about the webkit-reviews mailing list