[webkit-reviews] review canceled: [Bug 209718] Validate `dayInYear` parameter in monthFromDayInYear() using debug assertions : [Attachment 394867] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 29 10:55:23 PDT 2020


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 209718: Validate `dayInYear` parameter in monthFromDayInYear() using debug
assertions
https://bugs.webkit.org/show_bug.cgi?id=209718

Attachment 394867: Patch v1

https://bugs.webkit.org/attachment.cgi?id=394867&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 394867
  --> https://bugs.webkit.org/attachment.cgi?id=394867
Patch v1

I think using UNUSED_VARIABLE() or a similar macro would be better here.

Should I make a new macro that has a more explicit name like
IGNORE_UNUSED_VARIABLE_WRITE()?


More information about the webkit-reviews mailing list