[webkit-reviews] review granted: [Bug 209718] Validate `dayInYear` parameter in monthFromDayInYear() using debug assertions : [Attachment 394867] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 209718: Validate `dayInYear` parameter in monthFromDayInYear() using debug
assertions
https://bugs.webkit.org/show_bug.cgi?id=209718

Attachment 394867: Patch v1

https://bugs.webkit.org/attachment.cgi?id=394867&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 394867
  --> https://bugs.webkit.org/attachment.cgi?id=394867
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=394867&action=review

Not sure why the static analyzer trusts our assertions

> Source/WTF/wtf/DateMath.h:351
> +    ASSERT(d < (step + 31));

No need for the parentheses here