[webkit-reviews] review granted: [Bug 209613] Unable to present file upload picker after interactively dismissing a previously opened picker : [Attachment 394660] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 29 09:19:39 PDT 2020
Daniel Bates <dbates at webkit.org> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 209613: Unable to present file upload picker after interactively dismissing
a previously opened picker
https://bugs.webkit.org/show_bug.cgi?id=209613
Attachment 394660: Patch
https://bugs.webkit.org/attachment.cgi?id=394660&action=review
--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 394660
--> https://bugs.webkit.org/attachment.cgi?id=394660
Patch
This patch looks good. A better solution would include a test for this change
or a test for the crash (or both). I think it's testable from layout tests. See
internals.cpp
More information about the webkit-reviews
mailing list