[webkit-reviews] review granted: [Bug 209669] [AutoSizing] Bring back the old auto-sizing code as a deprecated codepath for compatibility reasons : [Attachment 394809] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 209669: [AutoSizing] Bring back the old auto-sizing code as a deprecated
codepath for compatibility reasons
https://bugs.webkit.org/show_bug.cgi?id=209669

Attachment 394809: Patch

https://bugs.webkit.org/attachment.cgi?id=394809&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 394809
  --> https://bugs.webkit.org/attachment.cgi?id=394809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394809&action=review

This looks OK but I’m very surprised that we are not adding any tests for this

> Source/WebCore/page/FrameView.h:710
> +    enum class AutoSizeMode : uint8_t { Default, Deprecated };

Could use bool instead of uint8_t. Do we know if one is superior?