[webkit-reviews] review granted: [Bug 209714] ScrollLatchingState should use WeakPtr<Element> : [Attachment 394856] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 29 01:13:02 PDT 2020


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 209714: ScrollLatchingState should use WeakPtr<Element>
https://bugs.webkit.org/show_bug.cgi?id=209714

Attachment 394856: Patch

https://bugs.webkit.org/attachment.cgi?id=394856&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 394856
  --> https://bugs.webkit.org/attachment.cgi?id=394856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394856&action=review

> Source/WebCore/page/scrolling/ScrollLatchingState.h:48
> +    void setWheelEventElement(Element*);

Does this need to accept null? Could it take a references instead of a pointer?

> Source/WebCore/page/scrolling/ScrollLatchingState.h:57
> +    void setPreviousWheelScrolledElement(Element*);

Ditto.

> Source/WebCore/page/scrolling/ScrollLatchingState.h:61
> +

Ditto.


More information about the webkit-reviews mailing list