[webkit-reviews] review granted: [Bug 209712] REGRESSION (r257867): [GPUP] Use-after-move in RemoteCDMInstance::createSession() : [Attachment 394852] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 209712: REGRESSION (r257867): [GPUP] Use-after-move in
RemoteCDMInstance::createSession()
https://bugs.webkit.org/show_bug.cgi?id=209712

Attachment 394852: Patch v1

https://bugs.webkit.org/attachment.cgi?id=394852&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 394852
  --> https://bugs.webkit.org/attachment.cgi?id=394852
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=394852&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteCDMInstance.cpp:94
>      auto session =
RemoteCDMInstanceSession::create(makeWeakPtr(m_factory.get()), WTFMove(id));
> -    m_factory->addSession(id, session.copyRef());
> +    m_factory->addSession(session->identifier(), session.copyRef());

How about just removing the WTFMove instead?

> Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.h:46
> +    RemoteCDMInstanceSessionIdentifier identifier() const { return
m_identifier; }

Seems like this is pretty far to go just to fix the use after move.